-
Notifications
You must be signed in to change notification settings - Fork 9
Add Vale for content linting to the repo #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 29 commits
887e0e0
2a2348c
b091a30
a0e8d26
ca5a045
e32d217
5293621
77fd9a0
915a6e8
d83fe9b
703f01e
e1d5b39
31dd235
6fead66
815e295
2076cd7
fa2ec11
36ddf8c
8539fe0
db62870
1f0983c
3d1617e
a2af066
f5201d8
7b25e03
808b1e7
bf1841f
f8aad48
a20c799
73fd5c1
3adfd7b
f53e939
3748887
245674e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,27 @@ | ||||||
| StylesPath = .github/styles | ||||||
|
|
||||||
| # https://github.com/errata-ai/packages | ||||||
| Packages = proselint,\ | ||||||
| write-good | ||||||
|
|
||||||
| [*.md] | ||||||
| BasedOnStyles = proselint,\ | ||||||
| Vale,\ | ||||||
| write-good | ||||||
|
|
||||||
| # Disable | ||||||
| Vale.Spelling = NO | ||||||
| write-good.E-Prime = NO | ||||||
| write-good.Passive = NO | ||||||
| write-good.TooWordy = NO | ||||||
|
|
||||||
| # Ignore lines starting with "> [!NOTE]" | ||||||
|
paddyroddy marked this conversation as resolved.
Outdated
|
||||||
| BlockIgnores = (?s)> \[!NOTE\].*?(\n|$) | ||||||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This replaces the inline comment before @matt-graham
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Eeeeeh what about
Suggested change
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah they would be
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah so it was the would avoid unintentionally capturing other characters with
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just spotted that you've already covered all altert types in last commit 73fd5c1 - I still don't entirely understand the regex but it works
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also, I assume you meant
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah bad news, yours doesn't work
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So in the example linked to in the docs there it looks like it's excluding the whole block
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Went with
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah we want to just ignore the top line itself, not the contents within it. Your regex doesn't work, feel free to try it yourself locally (run |
||||||
|
|
||||||
| # `vale sync` in CI means the packages are then linted, so turn them off | ||||||
| [.github/styles/**] | ||||||
| BasedOnStyles = | ||||||
|
|
||||||
| # Don't modify licence files | ||||||
| [**/LICENSE*] | ||||||
| BasedOnStyles = | ||||||
|
paddyroddy marked this conversation as resolved.
Outdated
|
||||||
Uh oh!
There was an error while loading. Please reload this page.