Skip to content

fix: add box shadow instead of outline for all focusable elements and some spacing to the elements #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samcunliffe merged 2 commits into from
Jun 17, 2025
Merged

fix: add box shadow instead of outline for all focusable elements and some spacing to the elements #552

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9c8686
fix: add box shadow instead of outline for all focusable elements, ad…
cuteshaun Jun 16, 2025
126f63f
fix: add spaces to css comments
cuteshaun Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions docs/_includes/header_custom.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
<button class="btn js-toggle-dark-mode" aria-label="Switch to light mode">
☼
</button>
<div class="js-toggle-dark-mode-wrapper">
<button
class="btn js-toggle-dark-mode"
aria-label="Switch to light mode"
type="button"
>
☼
</button>
</div>

<script>
const toggleDarkMode = document.querySelector(".js-toggle-dark-mode");
Expand Down
38 changes: 38 additions & 0 deletions docs/_sass/custom/custom.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
:root {
--outline-color: #{$outline-color-light};
}

[data-theme="dark"] {
--outline-color: #{$outline-color-dark};
}

html,
body {
height: 100%;
Expand Down Expand Up @@ -66,3 +74,33 @@ main {
background-color: $label-error-bg;
}
}

//Outline styles
Copy link
Copy Markdown
Member

@paddyroddy paddyroddy Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would tend to put a space here

Suggested change
//Outline styles
// Outline styles

.search:focus-within,
.btn:focus,
.btn:active,
.btn:focus:hover,
a:focus-visible,
summary:focus-visible {
outline: none;
box-shadow: 0 0 0 3px var(--outline-color);
border-radius: 2px;
transition: box-shadow 0.2s ease;
}
Copy link
Copy Markdown
Member

@samcunliffe samcunliffe Jun 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed fix of

For example:
Screenshot 2025-06-17 at 09 40 35Screenshot 2025-06-17 at 09 40 40

C.f. James' original comment and screenshots in #534. (Also apparent in the video!)


.aux-nav .aux-nav-list-item {
padding: 5px;
}

.nav-list-item {
padding-left: 1px;
padding-right: 1px;
}

.js-toggle-dark-mode {
height: 100%;
}

.js-toggle-dark-mode-wrapper {
padding: 5px;
}
4 changes: 4 additions & 0 deletions docs/_sass/custom/setup.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,12 @@
$blue-400: #4da6ff;
$green-700: #00755c;
$red-600: #d13c3c;
$purple-500: rgba(215, 186, 255, 0.65);
Copy link
Copy Markdown
Member

@paddyroddy paddyroddy Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of interest why rgba here rather than a HEX?

Copy link
Copy Markdown
Contributor Author

@cuteshaun cuteshaun Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I used rgba because it’s easier to adjust the opacity by changing the last argument. There’s also the option to use hex with alpha, like #d13c3c65, where the last two control opacity. However, I’m not sure about browser support for that, and I’ve just got used to using rgba in these cases)

Copy link
Copy Markdown
Member

@paddyroddy paddyroddy Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation!

$lavender: #b69cff;

// Semantic mappings
$link-color-dark: $blue-400;
$label-success-bg: $green-700;
$label-error-bg: $red-600;
$outline-color-light: $lavender;
$outline-color-dark: $purple-500;
⚡