Fix grep pattern in example for readSingleCellExperiment#94
Closed
michabirklbauer wants to merge 1 commit into
Closed
Fix grep pattern in example for readSingleCellExperiment#94michabirklbauer wants to merge 1 commit into
michabirklbauer wants to merge 1 commit into
Conversation
cvanderaa
added a commit
that referenced
this pull request
May 28, 2025
Member
|
Hi @michabirklbauer, Thank you very much for raising the point and for the PR for which the solution is spot on. But silly me, I thought you raised an issue and I just realised now this was a PR 🤦♂️ I implemented the same solution in 18ed500. So I'll close the PR without merging, but many thanks for the contribution! 🙏 |
Member
|
Indeed, thank you @michabirklbauer - I have added a contributors section in the README file. |
Author
|
All good, wouldn't have been necessary to add me as contributor - but thanks and thanks for fixing! 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I think the grep pattern in the current example for
readSingleCellExperimentis not correct, as it returns no quant columns and therefore the SingleCellExperiment contains no data. I believe the pattern from your vignette is the correct one and fixes that.Best,
Micha