starboard: support starring system messages, including those in #starboard#221
Open
katrinafyi wants to merge 2 commits intomainfrom
Open
starboard: support starring system messages, including those in #starboard#221katrinafyi wants to merge 2 commits intomainfrom
katrinafyi wants to merge 2 commits intomainfrom
Conversation
psycopg2-binary and greenlet used c/c++ bindings and failed to build on this python version
including system messages originating inside starboard. this changes the lookup logic to attempt both kinds of lookups (both received message and starboard message), allowing for starboard messages to be mixed with original messages in the starboard channel. this also changes the referenced message handling to attempt to fetch the referenced message if it has not been resolved. this gets us the full pinned message for pins_add events. also tweaks the display of referenced messages to handle kinds of reference which are not a reply. in delete, we also have to use `db_session.delete(entry)` instead of `entry.delete()`. i do not know why - renamed method after update, maybe?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this changes the lookup logic to attempt both kinds of lookups
(both received message and starboard message), allowing for
starboard messages to be mixed with original messages in the starboard
channel.
this also changes the referenced message handling to attempt to fetch
the referenced message if it has not been resolved. this gets us the
full pinned message for pins_add events.
also tweaks the display of referenced messages to handle kinds of
reference which are not a reply.
in delete, we also have to use
db_session.delete(entry)instead ofentry.delete(). i do not know why - renamed method after update, maybe?it looks something like this:
i have butchered the code in the process of testing. this should be cleane dup before merging.
it's a miracle this works, so please tell me if i have broken anything. or, feel free to ignore this pr and fix it properly.