Vcsaddons histo polar

[aashish24]

No description provided.

[aashish24]

Ref: #1999

[aashish24]

@chaosphere2112 cdtime.reltime is a function and not a class so the change

isinstance(v, cdtime.reltime) is invalid and that's why broke many tests on my machine. I pushed a fix on this branch and also created a ticket for it (#2026). I think both reltime and comptime should be classes (as you and I would expect).

[aashish24]

this is ready to be merged now. I am going to do a clean build run all the tests and merge it.

[danlipsa]

@chaosphere2112 @aashish24
534 - vcs_addons_test_histogram_defaults (Failed)
535 - vcs_addons_test_histogram_inherit (Failed)
536 - vcs_addons_test_polar (Failed)
537 - vcs_addons_test_polar_inherit (Failed)
538 - vcs_addons_test_convert_arrays (Failed)
539 - vcs_addons_test_polar_degrees (Failed)
540 - vcs_addons_test_polar_annual (Failed)
541 - vcs_addons_test_polar_diurnal (Failed)
542 - vcs_addons_test_polar_seasonal (Failed)
543 - vcs_addons_test_polar_semidiurnal (Failed)
fail for me on the master branch.

For the first test I get:
[~/projects/uvcdat/build]$ "/home/danlipsa/projects/uvcdat/build/install/bin/python" "/home/danlipsa/projects/uvcdat/src/testing/vcsaddons/test_vcs_addons_histogram_defaults.py" "/home/danlipsa/projects/uvcdat/build/uvcdat-testdata/baselines/vcsaddons/test_vcs_addons_histogram_defaults.png"
Traceback (most recent call last):
File "/home/danlipsa/projects/uvcdat/src/testing/vcsaddons/test_vcs_addons_histogram_defaults.py", line 12, in
histo.plot(vals, bg=True, x=x)
File "/home/danlipsa/projects/uvcdat/build/install/lib/python2.7/site-packages/vcsaddons/histograms.py", line 132, in plot
dsp = template.plot(data,self,bg=bg)
TypeError: plot() takes at least 4 arguments (4 given)

Do I have to install something?

[chaosphere2112]

@danlipsa There was an update to vcs in addition to the update to vcsaddons; that might be the source of your problems, not sure.

[aashish24]

@danlipsa I didn't see these failures on my machine when built from scratch. I will have a look tonight.