Skip to content

Commit 20a8db5

Browse files
authored
Merge pull request #1532 from NetCDF-World-Domination-Council/ejh_cmake_unit_tests
Adding rest of unit_tests to CMake build, but not running them on Windows
2 parents 31f1895 + 14f2b50 commit 20a8db5

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

CMakeLists.txt

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -927,8 +927,12 @@ IF(ENABLE_TESTS)
927927
OPTION(ENABLE_FAILING_TESTS "Run tests which are known to fail, check to see if any have been fixed." OFF)
928928

929929
###
930-
# Option to turn on unit testing. See https://github.com/Unidata/netcdf-c/pull/1472 for more information.
931-
# Currently (August 21, 2019): Will not work with Visual Studio
930+
# Option to turn on unit testing. See
931+
# https://github.com/Unidata/netcdf-c/pull/1472 for more
932+
# information. Currently (August 21, 2019): Will not work with
933+
# Visual Studio. The unit tests are for internal netCDF functions,
934+
# so we don't want to make them external, which would be required to
935+
# run on Windows.
932936
###
933937
IF(NOT MSVC)
934938
OPTION(ENABLE_UNIT_TESTS "Run Unit Tests." ON)

unit_test/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
# Some unit testing
1212

13-
SET(UNIT_TESTS tst_nclist)
13+
SET(UNIT_TESTS tst_nclist test_ncuri test_pathcvt)
1414

1515
IF(ENABLE_NETCDF_4)
1616
SET(UNIT_TESTS ${UNIT_TESTS} tst_nc4internal)

0 commit comments

Comments
 (0)