Adding rest of unit_tests to CMake build, but not running them on Windows#1532
Merged
WardF merged 4 commits intoUnidata:masterfrom Jan 7, 2020
Merged
Conversation
Member
|
Thanks Ed. Checking these now as part of starting to prep |
Contributor
Author
|
@WardF don't thank me yet - I just turned them on for windows to se what appveyor will tell me. I expect it will fail. ;-) But no doubt be a character-building experience for me. |
edhartnett
changed the title
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1458
Turning on rest of unit tests in CMake build, seeing if they work on Windows...
they do not. And to make them work we would need to EXTERNL every internal function we are testing in the unit_test directory. This is not something we want to do, so I suspect unit_test directory will never run on Windows, which I think is OK.