nccopy must use defaulting when there are no -c parameters#1438
Merged
WardF merged 3 commits intoUnidata:masterfrom Jul 18, 2019
Merged
nccopy must use defaulting when there are no -c parameters#1438WardF merged 3 commits intoUnidata:masterfrom
WardF merged 3 commits intoUnidata:masterfrom
Conversation
re: issue Unidata#1436 It used to be that when no -c parameters were specified (and the input was some variant of netcdf-3) that nccopy let the netcdf-c library decide on any default chunking. Now, it attempts to do it itself and is not doing it correctly when unlimited dimensions are involved. So fix is to revert to previous behavior. Note: The chunking rules are getting too complicated; consider revising.
Member
|
@DennisHeimbigner Would you mind updating the RELEASE_NOTES.md with a note regarding this? I can also merge it and then update the file if that's easier. Thanks! |
Collaborator
Author
|
ok, will do. |
Collaborator
Author
|
Ok, Updated RELEASE_NOTES |
Member
|
Well, merging after travis succeeds. It had succeeded before, not sure why it failed now, restarted the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It used to be that when no -c parameters were specified
(and the input was some variant of netcdf-3) that nccopy
let the netcdf-c library decide on any default chunking.
Now, it attempts to do it itself and is not doing it
correctly when unlimited dimensions are involved.
So fix is to revert to previous behavior.
Note: The chunking rules are getting too complicated; consider revising.