Remove obsolete _CRAYMPP and LOCKNUMREC macros#1464
Merged
WardF merged 22 commits intoUnidata:masterfrom Aug 21, 2019
Merged
Conversation
Contributor
Author
|
Travis failed due to: I'll commit a change to this branch and try again. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1459.
The obsolete macros _CRAYMPP and LOCKNUMREC were in use on an ancient version of a Cray. They would no longer work on modern Crays, which use MPI and the nc_open_par/nc_create_par functions for parallel I/O.
This will have no effect on existing users, since no could build with these macros - they are not supported in the configure.ac file.
This PR contains PR #1463, and should be inspected after that one is merged.