Git Cleanup, Fix for #1486

[WardF]

• Fixes netcdf-4.7.1 creates Bus Error when testing ncgen3 #1486

Some misc. cleanup, and a bug fix that found its way into this branch.

[dopplershift]

The bus error was caused by const???

[WardF]

I suspect that the compiler was protecting the memory, thus when we tried to manipulate the memory through pointer ‘magic’, we saw the bus error: 10 error. I couldn’t find anything saying what we were doing was undefined or illegal, but it would make sense given the observed behavior. It also appears to be platform specific, although disabling SIP on OSX had no effect.

[niziak]

Hi. I hit SEGFAULT on Linux using v4.7.1 so I find issue where code is trying to modify read only (protected) memory. I saw also multiple commits changing problematic code.

• First commit 6934aa2 introduced protections for variables adding const keyword. Which is good I think.
• Then where const protection start working instead of fixing cause - protection was was removed because it became "problematic": d001ec8
• And last 91d3a89 adds direct writing a values to variables.

Why the initialisation in loop is needed when there is a compile-time default value assigned (e.g. = {0};) ?
This change should be enough: 253d8fb