added version number to dispatch table, and check it in nc_def_user_format()#1635
Merged
WardF merged 13 commits intoUnidata:masterfrom Feb 26, 2020
NOAA-GSD:ejh_dispatch
Merged
added version number to dispatch table, and check it in nc_def_user_format()#1635WardF merged 13 commits intoUnidata:masterfrom NOAA-GSD:ejh_dispatch
WardF merged 13 commits intoUnidata:masterfrom
NOAA-GSD:ejh_dispatch
Conversation
Contributor
Author
|
@WardF this PR should be merged before next release. It contains some additional checking that Dennis suggested for user-defined formats. We want to get those new checks out as soon as possible. Thanks! |
Contributor
Author
|
Thanks @WardF ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1599
Fixes #1031
As discussed with @DennisHeimbigner in this PR a version number is added to the dispatch table, and checked by nc_def_user_format().
If the version number is incorrect, nc_def_user_format() rejects with dispatch table with NC_EINVAL.
This is to help ensure that the dispatch table used by PIO and other third party libraries is correct.