Return error on attempt to set chunking on scalar var#1662
Merged
WardF merged 4 commits intoUnidata:masterfrom Mar 6, 2020
NOAA-GSD:ejh_scalar_chunking
Merged
Return error on attempt to set chunking on scalar var#1662WardF merged 4 commits intoUnidata:masterfrom NOAA-GSD:ejh_scalar_chunking
WardF merged 4 commits intoUnidata:masterfrom
NOAA-GSD:ejh_scalar_chunking
Conversation
Contributor
Author
|
@WardF thanks for the quick merges! Here's the next round of changes. Note that this change does change library behavior, though hopefully in a way no user will experience. Attempts to set chunking on scalar vars used to be ignored, after this, that will return error. Similarly, previous code used to ignore attempts to set deflate on a scalar var, now that will return an error as well. Once this is merged I have several more ready to go, including the HDF5-1.20.0 changes. ;-) |
Member
|
No problem! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1644
Also updated documentation to note that nc_def_var_deflate, nc_def_var_filter cannot be used on scalar vars.