Use canonical path to derive name of dataset on Windows#2104
Merged
WardF merged 1 commit intoUnidata:mainfrom Mar 15, 2022
Merged
Use canonical path to derive name of dataset on Windows#2104WardF merged 1 commit intoUnidata:mainfrom
WardF merged 1 commit intoUnidata:mainfrom
Conversation
Collaborator
|
Good catch. Thanks. This might also be an issue inside the library in nc_create() and |
Contributor
Author
|
I haven't seen any sign of problems in The remaining test failures are: These failures are related to unicode and mmap support. I plan to look into them later. |
Member
|
Rebasing and retesting to see where it's at. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If #2084 is merged , netcdf utilities will use Windows paths on mingw-w64. This leads to problems in the output from
ncdump, such as the following error fromdap4_test/test_meta.sh:The default name of the dataset is supposed to be the basename of the input file, minus any file extension. The existing function
name_pathwhich determines the default dataset name assumes that paths have Unix directory separators (/), but Windows paths use\\. This PR produces a compatible path format using functionNCpathcanonicalinstead ofNCpathcvt.