vpath build: use top_srcdir

[wkliao]

No description provided.

[DennisHeimbigner]

This looks right to me.

[WardF]

Is there an equivalent change that needs to be made in CMakeLists.txt? I'll try to sort this out for myself before merging. Thanks!

[wkliao]

cmake always builds out of source.
So, github should have already captured the error if cmake is used in the workflow.

[wkliao]

It will be the best to move this PR to 4.9.0 milestone, as the latest main branch failed at make time when running a VPATH build. Below shows the configure command used and the error messages.

../netcdf-c/configure CC=mpicc \
      CPPFLAGS="-I$HDF5_DIR/include" \
      LDFLAGS="-L$HDF5_DIR/lib"

make
...
Making all in nczarr_test
cat: ../nc_test4/tst_quantize.c: No such file or directory
cat: ../nc_test4/tst_filter_avail.c: No such file or directory
make[2]: *** [Makefile:1730: test_quantize.c] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile:1735: test_filter_avail.c] Error 1
cat: ../nc_test4/tst_specific_filters.sh: No such file or directory
make[2]: *** [Makefile:1741: run_specific_filters.sh] Error 1
make[1]: *** [Makefile:744: all-recursive] Error 1
make: *** [Makefile:589: all] Error 2