Check for libcurl should only happen if DAP and/or ncZarr are enabled.#3018
Merged
WardF merged 2 commits intoUnidata:mainfrom Sep 11, 2024
Merged
Check for libcurl should only happen if DAP and/or ncZarr are enabled.#3018WardF merged 2 commits intoUnidata:mainfrom
WardF merged 2 commits intoUnidata:mainfrom
Conversation
… disabled when the functionality it requires has been disabled.
Collaborator
DennisHeimbigner
left a comment
DennisHeimbigner
left a comment
There was a problem hiding this comment.
This looks ok, but frankly I don't know if it captures all the dependencies correctly. At some point, we need to deal with the enormous set of dependencies in both the makefile and CMakeList.txt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @edwardhartnett for pointing out that #2907 only addressed
cmake-basedbuilds.