Skip to content

fix cmode bug#3270

Merged
WardF merged 2 commits intoUnidata:mainfrom
edhartnett:ejh_fix_mode
Mar 19, 2026
Merged

fix cmode bug#3270
WardF merged 2 commits intoUnidata:mainfrom
edhartnett:ejh_fix_mode

Conversation

@edhartnett
Copy link
Copy Markdown
Contributor

@edhartnett edhartnett commented Feb 18, 2026

Fixes #3269

These changes were generated with AI assistance but with human in the loop (me!) for every decision. I have personally reviewed every line of change in the PR and it is all of benefit to netcdf-c. These changes represent a serious attempt to improve netCDF and are in accordance with project practices and customs.

@edhartnett
Copy link
Copy Markdown
Contributor Author

This is failing due to #3272 and will work after #3273 is merged.

@edhartnett
Copy link
Copy Markdown
Contributor Author

@WardF it would be good to merge this and #3273, they are very small and focused, and both fix bugs.

@edhartnett
Copy link
Copy Markdown
Contributor Author

OK, after merging changes, including #3273, this PR now passes CI as expected.

This is ready to merge.

Copy link
Copy Markdown
Member

@WardF WardF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.

@WardF WardF merged commit ccf3984 into Unidata:main Mar 19, 2026
104 checks passed
@WardF
Copy link
Copy Markdown
Member

WardF commented Mar 19, 2026

Thanks!

@edhartnett edhartnett deleted the ejh_fix_mode branch April 12, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: add_user_type checks h5->cmode instead of h5->flags for define mode

2 participants