[5.x] work on filters package#966
Merged
haileyajohnson merged 5 commits intoUnidata:maint-5.xfrom Aug 22, 2022
Merged
Conversation
haileyajohnson
force-pushed
the
port-filters
branch
from
974bb8e to
fc033fb
Compare
haileyajohnson
force-pushed
the
port-filters
branch
from
fc033fb to
b78ecbb
Compare
haileyajohnson
force-pushed
the
port-filters
branch
from
b78ecbb to
5e3b884
Compare
haileyajohnson
force-pushed
the
port-filters
branch
2 times, most recently
from
b75477f to
6eb0866
Compare
haileyajohnson
force-pushed
the
port-filters
branch
from
6eb0866 to
ba53441
Compare
tdrwenski
reviewed
Aug 22, 2022
| } | ||
|
|
||
| // try by id next | ||
| int id = ((Short) oid).intValue(); |
Contributor
There was a problem hiding this comment.
maybe we should check that oid instanceof Short before casting here?
Contributor
Author
There was a problem hiding this comment.
we already checked that it's a Number, I think any Number type can cast to a Short without an exception
Contributor
There was a problem hiding this comment.
yeah, maybe I am overthinking it here, but could it happen that a filter does have a name but no provider for that name? then you reach this code without having checked if the oid instanceof Number
Co-authored-by: Tara Drwenski <tdrwenski@users.noreply.github.com>
…utBB.java Co-authored-by: Tara Drwenski <tdrwenski@users.noreply.github.com>
tdrwenski
approved these changes
Aug 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
PR Checklist
(e.g. "[5.x]: This is my PR title")
(these labels start with "port: ")
until ready for review