Skip to content

update icon paths within vscode source#440

Merged
stripedpajamas merged 1 commit intoVSCodium:masterfrom
Oekn5w:fix-welcome-icon
Jul 22, 2021
Merged

update icon paths within vscode source#440
stripedpajamas merged 1 commit intoVSCodium:masterfrom
Oekn5w:fix-welcome-icon

Conversation

@Oekn5w
Copy link
Copy Markdown
Contributor

@Oekn5w Oekn5w commented Jul 8, 2020

Fixes (hopefully) #406

This is based on the git diff command in the vscode repository

git diff --name-status 1.44.0 HEAD *.{svg,ico,png}

I don't have a development environment set up, I count on the PR build.

Edit: git diff output for clarity with PR changes in --><--:

D       extensions/markdown-language-features/media/preview-right-dark.svg
D       extensions/markdown-language-features/media/preview-right-light.svg
D       extensions/markdown-language-features/media/view-source-dark.svg
D       extensions/markdown-language-features/media/view-source-light.svg
A       extensions/npm/images/code.svg
D       src/vs/base/browser/ui/menu/menu.svg
D       src/vs/editor/browser/widget/media/diagonal-fill.png
D       src/vs/workbench/api/browser/media/test.svg
-->R100    src/vs/workbench/browser/parts/titlebar/media/code-icon.svg     src/vs/workbench/browser/media/code-icon.svg <--
D       src/vs/workbench/contrib/extensions/browser/media/defaultIcon.png
D       src/vs/workbench/contrib/preferences/browser/media/preferences-editor-dark.svg
D       src/vs/workbench/contrib/preferences/browser/media/preferences-editor-light.svg
-->D       src/vs/workbench/contrib/update/browser/media/code-icon.svg <--
D       src/vs/workbench/contrib/userDataSync/browser/media/check-dark.svg
D       src/vs/workbench/contrib/userDataSync/browser/media/check-light.svg
-->D       src/vs/workbench/contrib/welcome/code-icon.svg <--
R100    src/vs/base/test/node/encoding/fixtures/some.json.png   src/vs/workbench/services/textfile/test/node/encoding/fixtures/some.json.png
R100    src/vs/base/test/node/encoding/fixtures/some.xml.png    src/vs/workbench/services/textfile/test/node/encoding/fixtures/some.xml.png

@Oekn5w
Copy link
Copy Markdown
Contributor Author

Oekn5w commented Jul 9, 2020

Yes, working on linux x64:

image

@stripedpajamas
Copy link
Copy Markdown
Member

Thanks so much for finding this @Oekn5w ... we actually are in the process of switching to a different icon as a part of #413 . I will mention this path there to see if we can knock out two issues at once.

@stripedpajamas stripedpajamas mentioned this pull request Jul 13, 2020
@Oekn5w
Copy link
Copy Markdown
Contributor Author

Oekn5w commented Jul 13, 2020

@stripedpajamas I think this will also solve the Windows icon, can you please check this in your dev env?

@stripedpajamas
Copy link
Copy Markdown
Member

will do!

@Oekn5w
Copy link
Copy Markdown
Contributor Author

Oekn5w commented Jul 29, 2020

Closing this, as Windows also seems to work according to comment in #413.

Perhaps the workflow here can still help in future issues.

@Oekn5w Oekn5w closed this Jul 29, 2020
@Oekn5w Oekn5w deleted the fix-welcome-icon branch January 1, 2021 20:18
@Oekn5w Oekn5w restored the fix-welcome-icon branch February 10, 2021 09:08
@Oekn5w
Copy link
Copy Markdown
Contributor Author

Oekn5w commented Feb 10, 2021

Seeing as #582 reverted the logo change, I'll reopen this. @stripedpajamas please review against the current code base

@Oekn5w Oekn5w reopened this Feb 10, 2021
@stripedpajamas
Copy link
Copy Markdown
Member

Thanks for reopening, @Oekn5w. I will try building the PR against my branch and check the resulting Windows artifacts.

@Oekn5w
Copy link
Copy Markdown
Contributor Author

Oekn5w commented Jun 12, 2021

@stripedpajamas What's the status on this?

@stripedpajamas
Copy link
Copy Markdown
Member

Sorry for the long wait @Oekn5w -- I built your branch, just need to open it up on my Windows computer and we can merge this.

@stripedpajamas
Copy link
Copy Markdown
Member

Confirmed the welcome icon is correct on Windows builds. Thanks @Oekn5w

@stripedpajamas stripedpajamas merged commit 2ecbd09 into VSCodium:master Jul 22, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants