Updates types for TS 4.8#2307
Merged
kibertoad merged 1 commit intoVincit:masterfrom Sep 16, 2022
Merged
Conversation
Typescript 4.8 assumes that unconstrained types extend `unknown`, not `{}` (which is `unknown` minus `null` and `undefined`). However, many uses still need to extend `{}`. This PR does that explicitly for objection's types.
|
This would be very helpful |
|
@koskimas is it reasonable to merge this and make a release? This currently prevents the use of objection with latest typescript versions |
kibertoad
approved these changes
Sep 16, 2022
|
@kibertoad thank you for merging the PR. Do you have the ability to make a release containing this fix, or do you know if a release is planned in the near future? Thank you and other maintainers for all the work you do on this and other projects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typescript 4.8 assumes that unconstrained types extend
unknown, not{}(which isunknownminusnullandundefined). However, many uses still need to extend{}. This PR does that explicitly for objection's types.See https://devblogs.microsoft.com/typescript/announcing-typescript-4-8-beta/#unconstrained-generics-no-longer-assignable-to