Skip to content

Remove the source site from aggregatable reports and privacy budget key#445

Merged
csharrison merged 2 commits intomainfrom
pubkey
May 26, 2022
Merged

Remove the source site from aggregatable reports and privacy budget key#445
csharrison merged 2 commits intomainfrom
pubkey

Conversation

@csharrison
Copy link
Copy Markdown
Collaborator

Begins to addresses issue #439

@csharrison csharrison requested a review from johnivdel May 23, 2022 20:06
Copy link
Copy Markdown
Contributor

@johnivdel johnivdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csharrison csharrison merged commit eee7901 into main May 26, 2022
@csharrison csharrison deleted the pubkey branch May 26, 2022 18:35
aarongable pushed a commit to chromium/chromium that referenced this pull request May 31, 2022
See explainer update here:
WICG/attribution-reporting-api#445


Bug: 1329588
Change-Id: I4762cf57260bd957aac08aced5acafdc3987b756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3674678
Reviewed-by: John Delaney <johnidel@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1009256}
aarongable pushed a commit to chromium/chromium that referenced this pull request May 31, 2022
See explainer update here:
WICG/attribution-reporting-api#445


Bug: 1329588
Change-Id: Ibe9fa953802bbafadbee342858beece19b398816
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3674468
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1009322}
aarongable pushed a commit to chromium/chromium that referenced this pull request Jun 1, 2022
…reports"

This reverts commit 37319b8.

Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1330836#c1

Original change's description:
> [attribution-reporting] remove source_site from aggregatable reports
>
> See explainer update here:
> WICG/attribution-reporting-api#445
>
>
> Bug: 1329588
> Change-Id: Ibe9fa953802bbafadbee342858beece19b398816
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3674468
> Commit-Queue: Charlie Harrison <csharrison@chromium.org>
> Reviewed-by: John Delaney <johnidel@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1009322}

Bug: 1329588
Change-Id: I72d3dc9d9041e7e84ce26949595987a12c02f52e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3683141
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Owners-Override: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1009483}
aarongable pushed a commit to chromium/chromium that referenced this pull request Jun 1, 2022
…reports

Reland of crrev.com/c/3674468 which was reverted in crrev.com/c/3683141.

See explainer update here:
WICG/attribution-reporting-api#445

Bug: 1329588
Change-Id: Ifdf77622a58640a09ecf4600741f44aac9db8887
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3674468
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1009322}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3682194
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1009793}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants