Decouple --enable-s3 and --enable-nczarr in autotools#2
Open
mannreis wants to merge 4 commits intoWardF:s3-nczarr-cmake-ac-fix.wiffrom
Open
Decouple --enable-s3 and --enable-nczarr in autotools#2mannreis wants to merge 4 commits intoWardF:s3-nczarr-cmake-ac-fix.wiffrom
mannreis wants to merge 4 commits intoWardF:s3-nczarr-cmake-ac-fix.wiffrom
Conversation
…autotools behavior (in support of Unidata#3122" This reverts commit 42dbe33.
WardF
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow up on what I commented when reviewing Unidata#3149. In autotools using
--disable-nczarrwill silently skip evaluation of--enable-s3.However one should be able to enable s3 and disable zarr to have the ability to read
.nc&.nc4data via S3.This PR adds that build option, simply by moving the
enable-s3block out of theif test "x$enable_nczarr" = xyes ; thencondition.It also makes it a requirement on all OS flavours to find
sslandlibcryptosymbols when using the internal s3 implementation: configure.ac:L1020-L1025