Skip to content

fix: authConnectionId overwrites in vue-app-new demo#2448

Merged
chaitanyapotti merged 2 commits intomasterfrom
fix/vue-new-app-demo
Apr 13, 2026
Merged

fix: authConnectionId overwrites in vue-app-new demo#2448
chaitanyapotti merged 2 commits intomasterfrom
fix/vue-new-app-demo

Conversation

@lwin-kyaw
Copy link
Copy Markdown
Contributor

@lwin-kyaw lwin-kyaw commented Apr 13, 2026

Jira Link

Description

How has this been tested?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Note

Medium Risk
Updates Web3Auth login method connection ID generation in the demo; incorrect IDs would break passwordless login for certain networks/build envs, but scope is limited to demo configuration.

Overview
Fixes the vue-app-new demo’s passwordless login configuration by centralizing authConnectionId generation and adding support for groupedAuthConnectionId (notably for WEB3AUTH_NETWORK.SAPPHIRE_MAINNET) so email/SMS methods don’t get overwritten or miscomputed across networks.

Also simplifies authBuildEnv resolution to a single initialization based on VITE_APP_AUTH_BUILD_ENV with a dev/prod fallback.

Reviewed by Cursor Bugbot for commit 7fdbdee. Bugbot is set up for automated code reviews on this repo. Configure here.

@lwin-kyaw lwin-kyaw requested a review from a team as a code owner April 13, 2026 07:27
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web3auth-web Ready Ready Preview, Comment Apr 13, 2026 7:28am

Request Review

@chaitanyapotti chaitanyapotti merged commit e0ca680 into master Apr 13, 2026
7 checks passed
@chaitanyapotti chaitanyapotti deleted the fix/vue-new-app-demo branch April 13, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants