[Stack Switching] Fix GUFA on continuations#7824
Merged
kripken merged 19 commits intoWebAssembly:mainfrom Aug 13, 2025
Merged
Conversation
This reverts commit 444d8e0.
Member
Author
|
(actually, wait, this can be better) |
Member
Author
|
Should be ready now. Added a test + more precise computation of the continuation type. |
tlively
approved these changes
Aug 13, 2025
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
What happens before this change? A crash?
Member
Author
|
When GUFA thinks code is unreachable it will remove it or emit an unreachable after it. So it behaves differently if it is actually reached. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We must mark the blocks that Resumes target as receiving values, or else
GUFA will think they are unreachable, and optimize them away.