[Strings] Be stricter when checking builtin types#7829
Merged
Conversation
String builtins should not only have the expected signatures, they should also have the expected types. For example, if a builtin has a signature that is in a nontrivial rec group or has a supertype or is not final, that should be a validation error. Reject such incorrect types in StringLifting.
kripken
approved these changes
Aug 15, 2025
| @@ -0,0 +1,24 @@ | |||
| ;; The imported js string method here has the correct signature, but the wrong | |||
| ;; type. We shoudl error. | |||
Member
There was a problem hiding this comment.
Suggested change
| ;; type. We shoudl error. | |
| ;; type. We should error. |
Member
Author
There was a problem hiding this comment.
Oh wow, I even asked Gemini to proofread for me. Maybe I wrote this after doing that 😅
Member
There was a problem hiding this comment.
pleased to hear my job as proofreader (possibly) remains safe 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String builtins should not only have the expected signatures, they
should also have the expected types. For example, if a builtin has a
signature that is in a nontrivial rec group or has a supertype or is not
final, that should be a validation error. Reject such incorrect types in
StringLifting.