fix(utils): correctly escape image target in markdown#19259
Merged
Conversation
Do not assume mistletoe doing sanitization, do it before calling it.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens Weblate’s Markdown renderer by ensuring image src URLs are escaped before being interpolated into generated HTML, rather than relying on the Markdown library to do the right thing. This aligns with the existing “safer renderer” goal of preventing attribute injection via crafted Markdown.
Changes:
- Escape image
srcURLs when rendering<img>tags to prevent attribute injection. - Add regression tests covering malicious link/image targets and correct escaping of image titles/alt text.
- Document the behavior change in the 5.17.1 changelog.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
weblate/utils/markdown.py |
Escapes image URLs before emitting <img src="..."> HTML. |
weblate/utils/tests/test_markdown.py |
Adds test cases for URL attribute-injection attempts and escaping behavior; switches non-DB tests to SimpleTestCase. |
docs/changes.rst |
Notes the security/escaping behavior change in the release notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not assume mistletoe doing sanitization, do it before calling it.