Today date does not update after changing device date

[h-bomb]

If you change the device's date then return to the calendar, today (day color and/or selection) does not update.

Device(s): All
FSCalendar version: current (v2.7.2) / master branch
Occurs in sample project: Yes
Xcode version: 8.2.1

Steps to reproduce:

1. Launch the v2.7.2 Swift sample app.
2. Select any calendar project that shows today and note the selected / color of today.
3. Place the app in the background, go to Settings > General > Date & Time, toggle Set Automatically to off and change the date to a different date.
4. Return to the Swift sample app.

Result:

The calendar does not update today's date (selection or color).

Expected:

The calendar should always reflect the correct date for today. If today was selected before putting the app in background, the correct today day should be selected and today color updated. If a different date was selected before putting the app in the background, only the today day color should be updated (the last selected date should still be selected, but the selection color should be the non-today color.)

[WenchaoD]

Hi @h-bomb
Thanks for reporting this. A workaround for updating is to register notification observer for NSCalendarDayChangedNotification or UIApplicationSignificantTimeChangeNotification and call self.calendar.today = ... on receiving the notification.

[h-bomb]

Hi @WenchaoD - yes, that is what I did in my controller, but had an issue with setToday in the forked branch I've been working on:

if (![self.gregorian isDateInToday:today]) {

needed to change to (note the removal of the logical not (!)) to:

if ([self.gregorian isDateInToday:today]) {

Now I'm currently having a mysterious issue with our release build vs. our debug build - when running the release build, after changing the date and returning to the app, all of the days get highlighted with the today color. This doesn't occur in the debug build, though. Have you ever seen anything like this? Trying to debug now...

[h-bomb]

(Sorry for the accidental close / re-open @WenchaoD.)

I confirmed that the release build issue I mentioned above does occur in your latest Swift sample app.

Steps to reproduce:

1. In of the view controllers (in my case I used FSCalendarScopeExampleViewController), in viewDidLoad, add the following:

NotificationCenter.default.addObserver(self, selector: #selector(systemTimeChanged), name: NSNotification.Name.UIApplicationSignificantTimeChange, object: nil)

2. Add the method:

@objc fileprivate func systemTimeChanged() {
     calendar.today = Date()
}

3. Under the active scheme drop-down, select to Edit Scheme... and under Run, for Build Configuration, select Release and Close the dialogue. (Note that you will likely want to revert this setting later.)

4. Under the device drop-down, select a device to build and deploy to. You'll want to use a device so that you can make the date change while the app is in the background.

5. Build and deploy the app.

6. Select the FSCalenderScope project and note the selected / color of today (Should be blue).

7. Place the app in the background, go to Settings > General > Date & Time, toggle Set Automatically to off and change the date to a different date.

8. Return to the Swift sample app.

Result

The current date is selected with a blue selection circle, but all of the other days are selected with a red selection circle:

Expected

The current date should selected with a blue selection circle and all of the other days should not have a selection circle around them.

Note: If you swipe to another month and swipe back, the issue resolves itself.

[h-bomb]

@WenchaoD - I believe I have a solution to the second issue above. After our QA team confirms the fix, I'll post my solution.

[h-bomb]

@WenchaoD - the solution in the commit above fixed the Release build issue.

[WenchaoD]

I see. I've found a simpler solution. It works for me.