Conversation
talldan
added
[Type] Bug
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
It looks good from me the code perspective. I would be happy to have it confirmed from one of the designers, too.
| border-style: double; | ||
| } | ||
|
|
||
| &__cell-content { |
There was a problem hiding this comment.
@jasmussen - do we have any pattern for the placeholder in the table cell?
There was a problem hiding this comment.
@jasmussen Just thought I'd ping you again on this question in case you missed it. Cheers.
There was a problem hiding this comment.
Hope you don't mind, I've also added you as a reviewer based on Grzegorz' feedback.
There was a problem hiding this comment.
Sorry I missed the ping!
I think PR works well for me!
We don't have any pattern for placeholder text in tables, and I don't think we need it either. The table resembles a table in its natural state, and it's clear where you need to set the caret in order to type. Also, given table cells can grow very small, as this PR is about, it would be hard to add placeholder text that worked within those rules.
There was a problem hiding this comment.
Awesome - thanks for the reviews on this! 😃
Will merge now.
3 participants
Description
I noticed that it can be difficult to select very narrow table cells. The RichText element within the table cell is the element that receives selection. In the gif below the rich text has collapsed to just 1px wide and is hard to select:
This PR moves padding from the
tdelement to the RichText (just for the editor) so that there's a larger selection area.Pretty open to other suggestions of how to fix this - this seemed like the simplest.
How has this been tested?
Manually tested selection of a narrow cell
Screenshots
Gif showing the fix
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: