Fix script to launch Singularity container#1380
Merged
auphelia merged 1 commit intoXilinx:mainfrom Jun 30, 2025
Merged
Conversation
Collaborator
|
When I test it on our system, I don't get these unwanted quotes with the current implementation. But your change doesn't seem to break it for me either, so I suppose we can merge. |
fpjentzsch
approved these changes
Jun 30, 2025
Collaborator
|
Thank you @gabrielrodcanal! I will update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
The script
run-docker.shis currently broken for Singularity. The command generated contains unwanted quotes. See for example:This patch fixes the script so that FINN can be used in Singularity.