Add very basic ability to select song via http to music library#984
Add very basic ability to select song via http to music library#984theli-ua wants to merge 1 commit intoYARC-Official:devfrom
Conversation
|
Very basic version of #860 |
|
To clarify: this allows to open "yarg_host:9090" , be presented with basic list of songs in the library, upon clicking on them they will become selected in yarg |
|
This is more of PoC to get some general feedback on the idea I guess. If this is something that we want to actually do then probably will need more thought put into this |
|
Hey @theli-ua 👋 I've just checked this out and it works really well! It's quite surreal to see the YARG UI change itself, and browsing the song list whilst not using the main YARG instance is very neat. I think this PR could lay the foundation for a YARG app, which would be an excellent addition to parties where everyone can view the song list via their own phone/tablet. I'm sure this goes without saying (it's a PoC, after all!), but it's probably better for YARG itself to serve a JSON API over HTTP, rather than generating HTML within csharp. This would make the csharp side much easier to work with, and allow for a separate frontend team to pickup the HTML/JS/CSS side. Perhaps myself or the launcher contributors could then get involved with the UI for this project! If we go down the route of separating the app/api, I can see two options of how to serve the app:
To get this project started - perhaps we could go with option 1, and just bundle a html file along with YARG for now? Questions for you:
Thanks :) |
|
All of those suggestions are great. Though I don't know if anyone is actually interested in working on this or of any plans to do anything in this area. |
|
I'm interested in getting a frontend put together! Do you think you could mould this PR into a backend JSON server? It's halfway there already. Otherwise I'll tackle both if it's likely to be accepted. :) Essentially, |
No description provided.