Fix macros VA_ARGS#33
Open
Loki-Astari wants to merge 1 commit intoYasserAsmi:masterfrom
Loki-Astari:master
Open
Fix macros VA_ARGS#33Loki-Astari wants to merge 1 commit intoYasserAsmi:masterfrom Loki-Astari:master
Loki-Astari wants to merge 1 commit intoYasserAsmi:masterfrom
Loki-Astari:master
Conversation
Loki-Astari
commented
Sep 5, 2018
Using ... with zero arguments is non standard.
Fixed the use case.
Done by injecting an extra argument so that there is always at least one.
In these case add the empty string. Then append "%s" to the format.
The result should be the same. But the code is standard compliant.
Author
|
Hi I am trying to create a replacement for https://github.com/miloyip/nativejson-benchmark as Milo is not maintaining his version. My testing framework is here: https://github.com/Loki-Astari/JsonBenchmark I am currently trying to add jvar to the tests but can't because the code generates the error: The above fix should make your code standards compliant and allow me to include it in the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.