fix(scripts): add missing homedir import in persistent-mode.cjs#2181
Open
jonckr wants to merge 1 commit intoYeachan-Heo:devfrom
Open
fix(scripts): add missing homedir import in persistent-mode.cjs#2181jonckr wants to merge 1 commit intoYeachan-Heo:devfrom
jonckr wants to merge 1 commit intoYeachan-Heo:devfrom
Conversation
homedir() was called in getIdleCooldownSeconds() but never imported from 'os', causing a ReferenceError at runtime. Confidence: high Scope-risk: narrow
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
homedir()is called ingetIdleCooldownSeconds()(line 75) to build the config path~/.omc/config.json, but was never imported from Node'sosmodule. This causes aReferenceError: homedir is not definedat runtime whenever the idle notification cooldown logic is evaluated.Fix
Added
const { homedir } = require('os');to the require block at the top of the file.Evidence
The parallel
.mjsvariant (scripts/persistent-mode.mjs:25) already imports it correctly:import { homedir } from "os";Testing
node --check scripts/persistent-mode.cjspassesnpx tsc --noEmitpassesnpm run lintpassesnpm run buildpasses