fix(autopilot): pass sessionId to generateContinuationPrompt on failed transition#2182
Open
jonckr wants to merge 1 commit intoYeachan-Heo:devfrom
Open
fix(autopilot): pass sessionId to generateContinuationPrompt on failed transition#2182jonckr wants to merge 1 commit intoYeachan-Heo:devfrom
jonckr wants to merge 1 commit intoYeachan-Heo:devfrom
Conversation
…d transition When execution-to-qa phase transition fails, the continuation prompt was called without sessionId, unlike all other call sites at lines 281, 297, and 303. This caused session-scoped state lookups to fall back to legacy paths, potentially generating prompts for the wrong session. Confidence: high Scope-risk: narrow
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
src/hooks/autopilot/enforcement.tsline 276,generateContinuationPrompt(state, workingDir)is missing thesessionId3rd argument. This occurs in the execution-to-QA transition failure path. WithoutsessionId, session-scoped state lookups fall back to legacy paths, potentially generating continuation prompts for the wrong session.Fix
Added
sessionIdas the 3rd argument:generateContinuationPrompt(state, workingDir, sessionId)Evidence
All other call sites in the same function pass
sessionId:generateContinuationPrompt(state, workingDir, sessionId)generateContinuationPrompt(state, workingDir, sessionId)generateContinuationPrompt(state, workingDir, sessionId)Testing
npx tsc --noEmitpassesnpm run lintpassesnpm test -- --runpassesnpm run buildpasses