fix(scripts): return sessionPath instead of null when session state not found#2183
Open
jonckr wants to merge 1 commit intoYeachan-Heo:devfrom
Open
fix(scripts): return sessionPath instead of null when session state not found#2183jonckr wants to merge 1 commit intoYeachan-Heo:devfrom
jonckr wants to merge 1 commit intoYeachan-Heo:devfrom
Conversation
…ot found readStateFileWithSession returned path: null when no matching session state was found, causing shouldWriteStateBack to return false and silently skip all state updates. The .mjs counterpart correctly returns the sessionPath at this branch, ensuring writes proceed to the expected location. Confidence: high Scope-risk: narrow Directive: Return value must match the .mjs parallel implementation at scripts/persistent-mode.mjs line 364
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
scripts/persistent-mode.cjs,readStateFileWithSessionreturns{ state: null, path: null }when no matching session state is found. Thepath: nullreturn causesshouldWriteStateBackto returnfalse, silently skipping all state writes for that session.Fix
Changed
path: nulltopath: sessionPath, matching the.mjsimplementation.Evidence
The parallel
.mjsimplementation atscripts/persistent-mode.mjs:364correctly returns{ state: null, path: sessionPath }, preserving the intended write target.Testing
node --check scripts/persistent-mode.cjspassesnpx tsc --noEmitpassesnpm run lintpassesnpm run buildpasses