Fix deep-interview ambiguityThreshold runtime loading#2194
Open
Yeachan-Heo wants to merge 1 commit intodevfrom
Open
Fix deep-interview ambiguityThreshold runtime loading#2194Yeachan-Heo wants to merge 1 commit intodevfrom
Yeachan-Heo wants to merge 1 commit intodevfrom
Conversation
Builtin deep-interview skill templates documented an ambiguityThreshold in Claude settings, but the runtime loader always rendered the default threshold and a hardcoded 20% announcement. This change reads the configured threshold during skill materialization, applies it before the state-init instructions, and updates the startup copy to reflect the loaded percentage. Constraint: Keep the fix scoped to issue #2192 and avoid broad skill templating changes Rejected: Add a generic skill variable-expansion system | wider blast radius than the issue requires Confidence: high Scope-risk: narrow Reversibility: clean Directive: If additional deep-interview settings need runtime interpolation later, extend the deep-interview-specific loader path deliberately instead of broadening skill rendering by default Tested: npx vitest run src/__tests__/skills.test.ts -t "loads deep-interview ambiguityThreshold"; npx tsc --noEmit --pretty false; npx eslint src/features/builtin-skills/skills.ts src/__tests__/skills.test.ts Not-tested: Full Vitest suite
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
omc.deepInterview.ambiguityThresholdfrom Claude settings when materializing the built-in deep-interview skillTesting
npx vitest run src/__tests__/skills.test.ts -t "loads deep-interview ambiguityThreshold"npx tsc --noEmit --pretty falsenpx eslint src/features/builtin-skills/skills.ts src/__tests__/skills.test.tsCloses #2192