Open
Conversation
Issue #2193 comes from the installer treating skills as plugin-scoped even for standalone CLI setup. The fix keeps plugin-first behavior by default, but installs bundled skills automatically when no installed OMC plugin provides them and adds an explicit `omc setup --no-plugin` override for local development against a working checkout. Constraint: Keep the change scoped to installer/setup behavior without redesigning runtime skill precedence Rejected: Always install bundled skills on standalone setup | would duplicate plugin-provided skills for existing plugin users Rejected: Add only a manual flag with no auto-fallback | leaves npm-only installs broken by default Confidence: high Scope-risk: narrow Reversibility: clean Directive: Preserve plugin-first default behavior unless the user explicitly requests local skill sync or no plugin skills are detected Tested: npm test -- --run src/__tests__/installer-omc-reference.test.ts src/__tests__/setup-no-plugin-flag.test.ts Tested: npm test -- --run src/__tests__/installer-plugin-agents.test.ts Tested: npm run build Tested: Isolated CLI smoke run of `node bridge/cli.cjs setup --no-plugin --quiet` into a temp CLAUDE_CONFIG_DIR before reverting generated build artifacts Not-tested: Full Claude Code plugin runtime with marketplace-installed plugin enabled
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The installer now treats enabled-plugin state and plugin-provided skill files as separate checks so npm-only and no-plugin flows can sync bundled skills into ~/.claude/skills. Bundled skill sync now copies whole skill directories and re-syncs them, which keeps skill resources available and lets local skill edits be revalidated without relying on plugin cache. Constraint: Keep plugin-first behavior when an enabled OMC plugin already provides skills Constraint: Local skill installs must include skill resources beyond SKILL.md Rejected: Copy only SKILL.md files | breaks skills that reference bundled phase/resource files Rejected: Require --force for repeated no-plugin syncs | blocks local skill iteration on existing installs Confidence: high Scope-risk: narrow Reversibility: clean Directive: Preserve the distinction between plugin-enabled detection and plugin-cache presence when changing installer fallbacks Tested: npm test -- installer-omc-reference installer-plugin-agents; npx tsc --noEmit Not-tested: End-to-end Claude Code slash-command discovery against a real local npm install
Commander treats negated options as the positive key set to false, so was documented but the setup action looked for and never forwarded the override. This wires the negated option correctly and refreshes the committed CLI bundle so the actual binary matches the source behavior. Constraint: Keep the follow-up fix narrowly scoped to the explicit CLI override path Rejected: Rename the flag to avoid commander negation semantics | would churn the user-facing contract after the issue/PR already standardized on --no-plugin Confidence: high Scope-risk: narrow Reversibility: clean Directive: Negated commander flags map to the positive option name (), so do not read in future CLI wiring Tested: npm test -- --run src/__tests__/setup-no-plugin-flag.test.ts src/__tests__/installer-omc-reference.test.ts src/__tests__/installer-plugin-agents.test.ts Tested: node bridge/cli.cjs setup --help Tested: CLAUDE_CONFIG_DIR=<tmp> node bridge/cli.cjs setup --no-plugin --quiet with enabled-plugin fixtures installed 36 bundled skills Not-tested: Full npm package publish/install cycle outside the repository checkout
|
This PR has 1509 additions and 1043 deletions across 5 files. Consider breaking it into smaller PRs for easier review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
omc setupwhen no installed OMC plugin already provides themomc setup --no-pluginto force local skill sync from the current package for local developmentTesting
node bridge/cli.cjs setup --no-plugin --quietinto a tempCLAUDE_CONFIG_DIRCloses #2193.