This repository was archived by the owner on Sep 28, 2023. It is now read-only.
Conversation
> Tag | Usage | Description > --- | --- | --- > @access | private | Only used in limited circumstances, and only when private, such as for core-only functions or core classes implementing “private” APIs. Used directly below the @SInCE line in block. Source: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#phpdoc-tags If used at all, the `@access` tag should only be used on global functions/variables where the visibility can't be set via a modifier. After this commit, there are two `@access private` tags remaining. These are set for `public` methods. For those, it should be decided whether the method visibility is correct and if not, the method visibility should be changed. Either way, the tag should be removed after this has been examined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs: remove redundant
@accesstagsSource: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#phpdoc-tags
If used at all, the
@accesstag should only be used on global functions/variables where the visibility can't be set via a modifier.After this commit, there are two
@access privatetags remaining. These are set forpublicmethods.For those, it should be decided whether the method visibility is correct and if not, the method visibility should be changed.
Either way, the tag should be removed after this has been examined.
Docs: return values do not have a name