Skip to content

Bring back the whip message#12329

Merged
Dieterrr merged 1 commit intofeature/oauth-connection-uifrom
12163-add-whip-message
Mar 1, 2019
Merged

Bring back the whip message#12329
Dieterrr merged 1 commit intofeature/oauth-connection-uifrom
12163-add-whip-message

Conversation

@andizer
Copy link
Copy Markdown
Contributor

@andizer andizer commented Feb 26, 2019

This time we check against PHP version 5.6

Summary

This PR can be summarized in the following changelog entry:

  • Shows a notice on both the WordPress and Yoast dashboards when the current PHP version is below 5.6.

Relevant technical choices:

Test instructions

This PR can be tested by following these steps:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #12163

This time we check against PHP version 5.6
@andizer andizer added the UI change PRs that result in a change in the UI label Feb 26, 2019
@abotteram
Copy link
Copy Markdown
Contributor

CR 👍

@Dieterrr
Copy link
Copy Markdown
Contributor

Dieterrr commented Mar 1, 2019

Acceptance done 👍
Had to wait 4 week to get the dismissed message back but even that works as expected :)

@Dieterrr Dieterrr merged commit 6300cfc into feature/oauth-connection-ui Mar 1, 2019
@Dieterrr Dieterrr deleted the 12163-add-whip-message branch March 1, 2019 09:58
@Dieterrr Dieterrr modified the milestones: 10.0, 10.1 Mar 1, 2019
@IreneStr IreneStr added this to the Platform Plugin OAuth milestone Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI change PRs that result in a change in the UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants