Prevent filtered links from showing up in the sitemap#17983
Merged
diedexx merged 1 commit intofeature/indexable-sitemapsfrom Jan 27, 2022
Merged
Prevent filtered links from showing up in the sitemap#17983diedexx merged 1 commit intofeature/indexable-sitemapsfrom
diedexx merged 1 commit intofeature/indexable-sitemapsfrom
Conversation
herregroen
reviewed
Jan 25, 2022
b798b10 to
196893e
Compare
Member
Author
|
Merging this now so we can test the feature branch on staging. A CR can come later and feedback can be processed in a new branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
falsein thewpseo_sitemap_entryfilter to filter out sitemap entries for posts that are redirected. Other plugins can return similar values to prevent sitemap output.Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
lockey exists, as that's the only required key for the sitemap.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[Shopify]and I have added test instructions for Shopify.Documentation
Quality assurance