Skip to content

Add a check to remove optimisation notification for unindexed objects below threshold #19023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iolandasequino wants to merge 7 commits into
base: feature/SEO-optimization-threshold
Choose a base branch
from
+35 −0
Open

Add a check to remove optimisation notification for unindexed objects below threshold #19023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d1e7440
add check to remove optimisation notification if the unindexed object…
iolse Sep 30, 2022
6aec03e
Merge branch 'trunk' of github.com:Yoast/wordpress-seo into PC-684-do…
iolse Oct 3, 2022
013ea66
Merge branch 'feature/SEO-optimization-threshold' of github.com:Yoast…
iolse Oct 10, 2022
d15e893
Merge branch 'feature/SEO-optimization-threshold' of github.com:Yoast…
iolse Oct 10, 2022
aabd368
Merge branch 'feature/SEO-optimization-threshold' of github.com:Yoast…
agnieszkaszuba Oct 12, 2022
cbb9890
add unittests
hdvos Oct 13, 2022
1c13b28
Merge branch 'feature/SEO-optimization-threshold' of https://github.c…
marinakoleva Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/integrations/admin/indexing-notification-integration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,10 @@ protected function should_show_notification() {
if ( ! $this->environment_helper->is_production_mode() ) {
return false;
}
// Do not show optimization notification if the number of unindexed objects is less than 10 or less than 4% of the total objects number.
if ( ! $this->indexing_helper->should_show_optimization_button() ) {
return false;
}
// Don't show a notification if the indexing has already been started earlier.
if ( $this->indexing_helper->get_started() > 0 ) {
return false;
Expand Down
31 changes: 31 additions & 0 deletions tests/unit/integrations/admin/indexing-notification-integration-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,10 @@ public function test_create_notification_no_unindexed_items() {
->expects( 'is_production_mode' )
->andReturn( true );

$this->indexing_helper
->expects( 'should_show_optimization_button' )
->andReturn( true );

$this->indexing_helper
->expects( 'get_started' )
->andReturn( 0 );
Expand Down Expand Up @@ -293,6 +297,11 @@ public function test_create_notification_with_having_indexing_started() {
->expects( 'is_production_mode' )
->andReturn( true );

$this->indexing_helper
->expects( 'should_show_optimization_button' )
->andReturn( true );


$this->indexing_helper
->expects( 'get_started' )
->andReturn( 123456789 );
Expand Down Expand Up @@ -320,6 +329,10 @@ public function test_maybe_create_notification_with_indexing_failed_reason() {
->expects( 'is_production_mode' )
->andReturn( true );

$this->indexing_helper
->expects( 'should_show_optimization_button' )
->andReturn( true );

$this->indexing_helper
->expects( 'get_started' )
->andReturn( 0 );
Expand Down Expand Up @@ -371,6 +384,10 @@ public function test_maybe_create_notification_with_indexing_reasons( $reason )
->expects( 'is_production_mode' )
->andReturn( true );

$this->indexing_helper
->expects( 'should_show_optimization_button' )
->andReturn( true );

$this->indexing_helper
->expects( 'get_started' )
->andReturn( 0 );
Expand Down Expand Up @@ -454,6 +471,10 @@ public function test_maybe_cleanup_notification_when_there_is_something_to_index
->expects( 'is_production_mode' )
->andReturn( true );

$this->indexing_helper
->expects( 'should_show_optimization_button' )
->andReturn( true );

$this->notification_center
->expects( 'get_notification_by_id' )
->once()
Expand Down Expand Up @@ -489,6 +510,11 @@ public function test_maybe_cleanup_notification_when_the_user_has_started_indexi
->expects( 'is_production_mode' )
->andReturn( true );

$this->indexing_helper
->expects( 'should_show_optimization_button' )
->andReturn( true );


$this->notification_center
->expects( 'get_notification_by_id' )
->once()
Expand Down Expand Up @@ -521,6 +547,10 @@ public function test_maybe_cleanup_notification() {
->expects( 'is_production_mode' )
->andReturn( true );

$this->indexing_helper
->expects( 'should_show_optimization_button' )
->andReturn( true );

$this->notification_center
->expects( 'get_notification_by_id' )
->once()
Expand Down Expand Up @@ -556,6 +586,7 @@ public function test_create_notification_no_prod_site() {
->expects( 'is_production_mode' )
->andReturn( false );


$this->notification_center
->expects( 'add_notification' )
->never();
Expand Down
⚡