Skip to content

DUPP-732-revisit-checbox-group-stories-based-on-changes#19275

Merged
nolledgeable merged 8 commits intofeature/ui-library-3from
DUPP-732-revisit-checbox-group-stories-based-on-changes
Dec 6, 2022
Merged

DUPP-732-revisit-checbox-group-stories-based-on-changes#19275
nolledgeable merged 8 commits intofeature/ui-library-3from
DUPP-732-revisit-checbox-group-stories-based-on-changes

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

Context

  • Add documentation/story about CheckboxGroup children prop.

Summary

This PR can be summarized in the following changelog entry:

*Add documentation/story about CheckboxGroup children prop.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Open storybook and go to "CheckGroup" component and find children prop documentation and story.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Block/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unit tests to verify the code works as intended
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label and noted the work hours.

Fixes #

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Nov 24, 2022
@vraja-pro vraja-pro changed the base branch from trunk to feature/ui-library-3 November 24, 2022 15:59
@vraja-pro vraja-pro added this to the ui-library milestone Nov 29, 2022
@nolledgeable nolledgeable force-pushed the DUPP-732-revisit-checbox-group-stories-based-on-changes branch from 64c2dc7 to e2f36e0 Compare December 6, 2022 14:31
Copy link
Copy Markdown
Contributor

@nolledgeable nolledgeable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR & ACC ✅

Added disabled support to CheckboxGroup component also.

@nolledgeable nolledgeable merged commit e1fedcd into feature/ui-library-3 Dec 6, 2022
@nolledgeable nolledgeable deleted the DUPP-732-revisit-checbox-group-stories-based-on-changes branch December 6, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants