Skip to content

Dupp 808 settings UI bugs found in alpha test#19313

Merged
igorschoester merged 7 commits intotrunkfrom
DUPP-808-settings-ui-bugs-found-in-alpha-test
Nov 30, 2022
Merged

Dupp 808 settings UI bugs found in alpha test#19313
igorschoester merged 7 commits intotrunkfrom
DUPP-808-settings-ui-bugs-found-in-alpha-test

Conversation

@nolledgeable
Copy link
Copy Markdown
Contributor

@nolledgeable nolledgeable commented Nov 30, 2022

Context

  • Fixes various minor issues found during QA testing of new settings UI alpha.

Summary

This PR can be summarized in the following changelog entry:

  • Fixes various minor issues found during QA testing of new settings UI alpha.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Verify that this QA issue is no longer reproducible.
  • Verify that this QA issue is no longer reproducible.
  • Verify that the Discard changes modal (make a change, then click Discard changes in the footer) does not touch the viewport edges on mobile screens.

image

  • On Media pages: verify that the schema selects, when disabled through Enable media pages toggle, are no longer interact-able (you can't open the options list).

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Block/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unit tests to verify the code works as intended
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label and noted the work hours.

Fixes #
https://yoast.atlassian.net/browse/QA-4086
https://yoast.atlassian.net/browse/QA-4087

@nolledgeable nolledgeable added innovation Innovative issue. Relating to performance, memory or data-flow. changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels Nov 30, 2022
@nolledgeable nolledgeable added this to the 19.13 milestone Nov 30, 2022
@igorschoester igorschoester force-pushed the DUPP-808-settings-ui-bugs-found-in-alpha-test branch from 25f4ec1 to efc11ea Compare November 30, 2022 12:35
Copy link
Copy Markdown
Contributor

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR & ACC ✅

Note: rebased on trunk to get the version working nicely with Premium.
Might cause problems with the cherry picks?

@igorschoester igorschoester merged commit be1097e into trunk Nov 30, 2022
@igorschoester igorschoester deleted the DUPP-808-settings-ui-bugs-found-in-alpha-test branch November 30, 2022 12:44
@enricobattocchi enricobattocchi modified the milestones: 19.13, 19.14 Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog innovation Innovative issue. Relating to performance, memory or data-flow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants