Lowercase query before searching in new settings UI#19340
Merged
igorschoester merged 4 commits intotrunkfrom Dec 6, 2022
Merged
Lowercase query before searching in new settings UI#19340igorschoester merged 4 commits intotrunkfrom
igorschoester merged 4 commits intotrunkfrom
Conversation
igorschoester
suggested changes
Dec 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
toLowertostring.toLocaleLowerCasefor locale specific lowercasing.safeToLocaleLowerhelper that doesn't throw breaking errors whenlocaleis invalid.Force rewrite titlestoggle.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
SEOandseogive you the same search results.XMLandxmlgive you the same search results.Force rewrite titlestoggle is now the same width as toggles below it. This toggle is only visible in non block themes that don't support thetitle-tagDev only additional test
411ofsettings-integration.php, assign something invalid to theuserLocalevariable, ie.falseor10. Then verify that above lowercasing fails and you have console errors, but the new settings UI doesn't break.Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel and noted the work hours.Fixes #
https://yoast.atlassian.net/browse/DUPP-826