Skip to content

Settings UI: Remove code blocks from breadcrumb settings for post type or tax in s…#19347

Merged
pls78 merged 1 commit intotrunkfrom
DUPP-833-code-blocks-in-search-index
Dec 7, 2022
Merged

Settings UI: Remove code blocks from breadcrumb settings for post type or tax in s…#19347
pls78 merged 1 commit intotrunkfrom
DUPP-833-code-blocks-in-search-index

Conversation

@nolledgeable
Copy link
Copy Markdown
Contributor

@nolledgeable nolledgeable commented Dec 6, 2022

…earch index

Context

  • Move code blocks (JSX) from search index to search component (place of rendering).

Summary

This PR can be summarized in the following changelog entry:

  • Move code blocks (JSX) from search index to search component (place of rendering).

Relevant technical choices:

  • Used a RegExp in Search component to determine with what options we're dealing with based on fieldId.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Verify that searching for post will get you the Breadcrumbs for posts search result and that search result contains a code block with post type name post.
  • Optionally test for other post types.
  • Verify that searching for category will get you the Breadcrumbs for categories search result and that search result contains a code block with taxonomy name category.
  • Optionally test for other taxonomies.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Block/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • No impact outside of new settings UI.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unit tests to verify the code works as intended
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label and noted the work hours.

Fixes #
https://yoast.atlassian.net/browse/DUPP-833

@nolledgeable nolledgeable added innovation Innovative issue. Relating to performance, memory or data-flow. changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels Dec 6, 2022
@nolledgeable nolledgeable added this to the 19.13 milestone Dec 6, 2022
@pls78
Copy link
Copy Markdown
Member

pls78 commented Dec 7, 2022

CR && ACC: ✅

@pls78 pls78 merged commit 9db913d into trunk Dec 7, 2022
@pls78 pls78 deleted the DUPP-833-code-blocks-in-search-index branch December 7, 2022 11:27
@enricobattocchi enricobattocchi modified the milestones: 19.13, 19.14 Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog innovation Innovative issue. Relating to performance, memory or data-flow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants