Adds the possibility to add options to the Inclusive language assessor.#19360
Merged
FAMarfuaty merged 3 commits intotrunkfrom Dec 9, 2022
Merged
Conversation
FAMarfuaty
reviewed
Dec 9, 2022
| setInclusiveLanguageOptions( options ) { | ||
| this._inclusiveLanguageOptions = options; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
@hansjovis When we added additional methods in the worker like setCustomSEOAssessorClass, we also bind it inside the constructor. But we don't do it to setInclusiveLanguageOptions here. Do you know if "binding" or not "binding" it to the scope will have no difference for setInclusiveLanguageOptions?
Contributor
Author
There was a problem hiding this comment.
Yes, binding it inside of the constructor would be the best option. To avoid any edge cases when calling the method.
Could you implement that? 🙂 I don't have time at the moment.
FAMarfuaty
approved these changes
Dec 9, 2022
Contributor
FAMarfuaty
left a comment
There was a problem hiding this comment.
CR and Acceptance test 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
trunkinto this branch. This branch has been created based on the release branch, will be used in Shopify, and should not contain any unstable changes.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel and noted the work hours.Fixes https://yoast.atlassian.net/browse/PC-976