Skip to content

Settings UI: Update react-hotkeys-hook dep to 4.0.5 version#19383

Merged
thijsoo merged 1 commit intotrunkfrom
DUPP-838-bump-react-hotkeys-version
Dec 16, 2022
Merged

Settings UI: Update react-hotkeys-hook dep to 4.0.5 version#19383
thijsoo merged 1 commit intotrunkfrom
DUPP-838-bump-react-hotkeys-version

Conversation

@nolledgeable
Copy link
Copy Markdown
Contributor

@nolledgeable nolledgeable commented Dec 13, 2022

Context

  • Bumps react-hotkeys-hook dependency to newest version.

Summary

This PR can be summarized in the following changelog entry:

  • Bumps react-hotkeys-hook dependency to newest version.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Visit the new settings UI.
  • Verify that the QA issue is no longer reproducible.
  • Verify that cmd+k or ctrl+k (depending on OS) opens the search and focuses the search field.
  • Verify that cmd+k or ctrl+k (depending on OS) opens the search and focuses the search field while you're focused in a text field.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Block/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • No impact outside new settings UI.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unit tests to verify the code works as intended
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label and noted the work hours.

Fixes #
https://yoast.atlassian.net/browse/DUPP-838

@nolledgeable nolledgeable added innovation Innovative issue. Relating to performance, memory or data-flow. changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels Dec 13, 2022
@nolledgeable nolledgeable added this to the 19.14 milestone Dec 13, 2022
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR +ACC

@thijsoo thijsoo merged commit 4fdae99 into trunk Dec 16, 2022
@thijsoo thijsoo deleted the DUPP-838-bump-react-hotkeys-version branch December 16, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog innovation Innovative issue. Relating to performance, memory or data-flow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants