Skip to content

Add location context to synonyms upsell.#19391

Merged
pls78 merged 1 commit intorelease/19.14from
DUPP-859-the-add-synonyms-modal-has-a-rtu-link-that-doesnt-contain-a-context-parameter
Dec 16, 2022
Merged

Add location context to synonyms upsell.#19391
pls78 merged 1 commit intorelease/19.14from
DUPP-859-the-add-synonyms-modal-has-a-rtu-link-that-doesnt-contain-a-context-parameter

Conversation

@thijsoo
Copy link
Copy Markdown
Contributor

@thijsoo thijsoo commented Dec 14, 2022

Context

  • We missed one upsell link where want to add a context variable to the url.

Summary

This PR can be summarized in the following changelog entry:

  • Fixes a not released bug where the context get parameter was not added to two upsell links.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Disable premium and build this RC/pr for free.

  • Make sure every upsell link still works and ends up on: https://yoast.com/reasons-to-upgrade-keywords

  • Open a post in the Gutenberg editor.

  • In the metabox open the SEO analysis tab and click on the + Add synonyms button. In the modal make sure the Yoast SEO Premium link and the buy button both have a context parameter that is block-metabox.

  • Do the same for the sidebar and make sure the context parameter is block-sidebar.

*Open a post in the classic editor.

  • In the metabox open the SEO analysis tab and click on the + Add synonyms button. In the modal make sure the Yoast SEO Premium link and the but button both have a context parameter that is classic-metabox.

  • Open a post in Elementor.

  • In the sidebar open the SEO analysis tab and click on the + Add synonyms button. In the modal make sure the Yoast SEO Premium link and the but button both have a context parameter that is elementor-sidebar.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Block/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unit tests to verify the code works as intended
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label and noted the work hours.

Fixes #

@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Dec 14, 2022
@thijsoo thijsoo added this to the 19.14 milestone Dec 14, 2022
@pls78
Copy link
Copy Markdown
Member

pls78 commented Dec 16, 2022

CR && ACC: ✅

@pls78 pls78 merged commit 9d23d1a into release/19.14 Dec 16, 2022
@pls78 pls78 deleted the DUPP-859-the-add-synonyms-modal-has-a-rtu-link-that-doesnt-contain-a-context-parameter branch December 16, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants