Skip to content

Inclusive language - Small typo fixes in feedback strings#19400

Merged
agnieszkaszuba merged 3 commits intorelease/19.14from
PC-1050-PC-1053-PC-1054-small-fixes-for-inclusive-language
Dec 20, 2022
Merged

Inclusive language - Small typo fixes in feedback strings#19400
agnieszkaszuba merged 3 commits intorelease/19.14from
PC-1050-PC-1053-PC-1054-small-fixes-for-inclusive-language

Conversation

@hansjovis
Copy link
Copy Markdown
Contributor

@hansjovis hansjovis commented Dec 19, 2022

Context

  • Feedback strings for some Inclusive language assessments contained typos. This PR fixes those types.

Summary

This PR can be summarized in the following changelog entry:

  • Removes the word "dense" as a possible inclusive alternative for the potentially non-inclusive phrase "daft".
  • Replaces a forward slash ("/") with a comma (",") in the possible alternatives for the non-inclusive phrase "the undocumented".
  • Adds a missing "the" to the possible alternatives for the non-inclusive phrases "first world countries" and "first-world".

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Make sure that the Inclusive language feature is enabled within the Yoast SEO settings.

Removes the word "dense" as a possible inclusive alternative for the potentially non-inclusive phrase "daft".

  • Create a post or open an existing one.
  • Add a sentence to the post's content containing the phrase "daft".
  • You should see an orange traffic light with the feedback:

    Be careful when using daft as it is potentially harmful. Consider using an alternative, such as uninformed, ignorant, foolish, inconsiderate, irrational, reckless, unless referring to someone who explicitly wants to be referred to with this term.

Replaces a forward slash ("/") with a comma (",") in the possible alternatives for the non-inclusive phrase "the undocumented".

  • Create a post or open an existing one.
  • Add a sentence to the post's content containing the phrase "the undocumented".
  • You should see a red traffic light with the feedback:

    Avoid using the undocumented as it is potentially overgeneralizing. Consider using people who are undocumented, undocumented people, people without papers instead.

Adds a missing "the" to the possible alternatives for the non-inclusive phrases "first world countries" and "first-world".

  • Create a post or open an existing one.
  • Add a sentence to the post's content containing the phrase "first world countries".
  • You should see a red traffic light with the feedback:

    Avoid using first world countries as it is overgeneralizing. Consider using the specific name for the countries or regions instead.

  • Add a sentence to the post's content containing the phrase "first-world".
  • You should see a red traffic light with the feedback:

    Avoid using first-world as it is overgeneralizing. Consider using the specific name for the country or region instead.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Block/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • Since this only changes the text of the feedback of some Inclusive language assessments, no other impact (other than the assessments described in the test instructions) is expected.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unit tests to verify the code works as intended
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label and noted the work hours.

Fixes:

@hansjovis hansjovis added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Dec 19, 2022
@hansjovis hansjovis added this to the 19.14 milestone Dec 19, 2022
@agnieszkaszuba
Copy link
Copy Markdown
Contributor

CR & acceptance: 👍

@agnieszkaszuba agnieszkaszuba merged commit 03e30fb into release/19.14 Dec 20, 2022
@agnieszkaszuba agnieszkaszuba deleted the PC-1050-PC-1053-PC-1054-small-fixes-for-inclusive-language branch December 20, 2022 09:05
mhkuu added a commit that referenced this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants