Reverts changes to the highlighting feature

[mhkuu]

Context

Summary

This PR can be summarized in the following changelog entry:

• Reverts the changes introduced in PC-1029-anchors-containing-square-brackets-in-content-lead-to-errors-with-classic-editor #19373 and PC-965 Fixes highlighting when inline HTML tags are present in Classic editor and in Shopify #19162.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Classic editor

• Install and activate Classic editor
• Install and activate Yoast SEO
• Repeat the test instruction in this PR PC-965 Fixes highlighting when inline HTML tags are present in Classic editor and in Shopify #19162, and confirm that the text containing a link(s) are not highlighted
• Confirm that there is no error in the console

Test with text that doesn't contain link(s)

• Create a post with this text
  catnip.txt

Keyword density assessment

• Set the word catnip as the focus keyphrase
• Confirm that the keyphrase density assessment detects 8 occurrences of the keyphrase in the text
• Click on the eye icon and confirm that all 8 occurrences are highlighted
• Click the eye icon of keyword density assessment

Keyphrase distribution assessment

• Install and activate Yoast SEO premium
• Repeat the step in Keyword density assessment, and confirm that clicking on the eye icon of the Keyphrase distribution assessment will also highlight all 8 occurrences of focus keyphrase

Word complexity assessment

• Install and activate Yoast SEO premium
• Go to the previous post
• Go to the Readability analysis tab
• Confirm that complex words are highlighted

Sentence length, Passive voice, and Transition words assessment

• Go to the previous post
• Click on the eye icon of the sentence length assessment
• Confirm that all long sentences are highlighted
• Click on the eye icon of the passive sentence assessment
• Confirm that all sentences that contain passive voice are highlighted
• Click on the eye icon of the transition words assessments
• Confirm that all sentences with transition words are highlighted

Consecutive sentences assessment

• (Assessment not available for E-commerce content types)
• Go to the previous post
• Add these three sentences containing anchor links that start with the same words:

Cats detect nepetalactone through their olfactory epithelium, not through their vomeronasal organ. Cats detect nepetalactone through their olfactory epithelium, not through their vomeronasal organ. Cats detect nepetalactone through their olfactory epithelium, not through their vomeronasal organ.

• Click on the eye icon of the consecutive sentences assessment
• Confirm that the three sentences above are highlighted

Paragraph length assessment

• Go to the previous post
• Make one of the paragraphs longer than 150 words
• Click on the paragraph length assessment
• Confirm that the long paragraph is highlighted

Inclusive language analysis

• Go to the previous post
• In one of the sentences that don't contain links, add a non-inclusive word like, "seniors", "policemen" etc.
• Click on the eye icon of the feedback
• Confirm that sentence that contains the non-inclusive word is highlighted

Block editor

• Repeat the test instruction in Classic editor
• Confirm that highlighting works for text that contains links and text that doesn't contain links.

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Block/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change.

Quality assurance

• I have tested this code to the best of my abilities
• I have added unit tests to verify the code works as intended
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label and noted the work hours.

Fixes (well, reverts changes that lead to...) https://yoast.atlassian.net/browse/PC-1062

[FAMarfuaty]

I also smoke test with the ACF plugin activated.