Skip to content

Fix encoding of Hungarian sampleVocabulary.json#20373

Merged
agnieszkaszuba merged 1 commit intoYoast:trunkfrom
szepeviktor:fix-hu-encoding
Apr 15, 2026
Merged

Fix encoding of Hungarian sampleVocabulary.json#20373
agnieszkaszuba merged 1 commit intoYoast:trunkfrom
szepeviktor:fix-hu-encoding

Conversation

@szepeviktor
Copy link
Copy Markdown
Contributor

@szepeviktor szepeviktor commented May 29, 2023

Context

The source file is not in UTF-8.

Summary

This PR can be summarized in the following changelog entry:

  • Fixes the encoding of a Hungarian test file to use UTF-8. Props to @szepeviktor .
  • [yoastseo] Fixes the encoding of the spec/languageProcessing/languages/hu/helpers/internal/stemmerCoverage/sampleVocabulary.json test file to use UTF-8.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  1. Temporarily comment out the following line in the yoastseo/jest.config.js file: <rootDir>/spec/languageProcessing/languages/[a-z][a-z]/helpers/internal/stemmerCoverage/generateStems.js
  2. Run the following test file in your terminal: yoastseo/spec/languageProcessing/languages/hu/helpers/internal/stemmerCoverage/generateStems.js (use the actual terminal, this may not work in the IDE terminal).
  3. Confirm that a list of Hungarian words and stems is printed out in the terminal, like: [["abazinok","abazin"],["abazin","abaz"],["abbahagyja","abbahagy"],["abbahagyni","abbahagyn"],["abbahagynám","abbahagyna"],....

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • No QA needed, the change only affects a local test file.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.
  • This PR also affects Yoast SEO for Google Docs. I have added a changelog entry starting with [yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached the Google Docs Add-on label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • [] I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have run grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@szepeviktor szepeviktor changed the title Fix encoding of sampleVocabulary.json Fix encoding of Hungarian sampleVocabulary.json May 29, 2023
@szepeviktor
Copy link
Copy Markdown
Contributor Author

@JorPV Could you help me get this PR merged/closed?

@agnieszkaszuba agnieszkaszuba added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Apr 15, 2026
@agnieszkaszuba
Copy link
Copy Markdown
Contributor

Thanks for your contribution and your patience @szepeviktor, I will merge the fix!

@agnieszkaszuba agnieszkaszuba merged commit 5195bae into Yoast:trunk Apr 15, 2026
4 checks passed
@szepeviktor
Copy link
Copy Markdown
Contributor Author

Glad to contribute.

@agnieszkaszuba agnieszkaszuba added this to the 27.6 milestone Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog community-patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants