Fixes grunt check warnings in yoastseo

packages/yoastseo/package.json

@@ -28,7 +28,7 @@
     "clean": "rm -rf build",
     "pretest": "grunt get-premium-configuration",
     "test": "jest",
-    "lint": "eslint src",
+    "lint": "eslint src spec --max-warnings 12",
     "prepublishOnly": "yarn build"
   },
   "engines": {

packages/yoastseo/spec/appSpec.js

@@ -34,7 +34,7 @@ describe( "Creating an App", function() {
 		expect( function() {
 			new App( {
 				callbacks: {
-					getData: function() {
+					getData: () => {
 						return {};
 					},
 				},
@@ -60,7 +60,7 @@ describe( "Creating an App", function() {
 					output: "outputID",
 				},
 				callbacks: {
-					getData: function() {
+					getData: () => {
 						return {};
 					},
 				},
@@ -74,7 +74,7 @@ describe( "Creating an App", function() {
 				output: "outputID",
 			},
 			callbacks: {
-				getData: function() {
+				getData: () => {
 					return {};
 				},
 			},
@@ -90,7 +90,7 @@ describe( "Creating an App", function() {
 				snippet: "snippetID",
 			},
 			callbacks: {
-				getData: function() {
+				getData: () => {
 					return {};
 				},
 			},
@@ -104,7 +104,7 @@ describe( "Creating an App", function() {
 				output: "outputID",
 			},
 			callbacks: {
-				getData: function() {
+				getData: () => {
 					return {};
 				},
 			},

packages/yoastseo/spec/config/getTransliterationsSpec.js

@@ -0,0 +1,22 @@
+import getTransliterations, { transliterations } from "../../src/config/getTransliterations";
+
+describe( "A test for retrieving transliterations for a specific locale", () => {
+	it( "should return the transliteration object for `nbnn` when the locale is either 'nb_NO' or 'nn_NO'", () => {
+		expect( getTransliterations( "nb_NO" ) ).toEqual( transliterations.nbnn );
+		expect( getTransliterations( "nn_NO" ) ).toEqual( transliterations.nbnn );
+	} );
+	it( "should return the transliteration object for `ca` when the locale is either 'bal' or 'ca'", () => {
+		expect( getTransliterations( "bal" ) ).toEqual( transliterations.ca );
+		expect( getTransliterations( "ca" ) ).toEqual( transliterations.ca );
+	} );
+	it( "should return the transliteration object from the array when the key for the specific locale is available in the array", () => {
+		expect( getTransliterations( "es_AR" ) ).toEqual( transliterations.es );
+		expect( getTransliterations( "pt_PT" ) ).toEqual( transliterations.pt );
+	} );
+	it( "should return an empty array when the key for the specific locale is not available in the array", () => {
+		expect( getTransliterations( "jv_ID" ) ).toEqual( [] );
+	} );
+	it( "should return an empty array when no locale is passed", () => {
+		expect( getTransliterations() ).toEqual( [] );
+	} );
+} );

packages/yoastseo/spec/helpers/formatNumberSpec.js

@@ -2,6 +2,7 @@ import formatNumberSpec from "../../src/helpers/formatNumber.js";
 
 describe( "a test to round numbers to two decimal places", function() {
 	it( "returns a rounded number", function() {
+		// eslint-disable-next-line no-loss-of-precision
 		expect( formatNumberSpec( 9.7895437583789573 ) ).toBe( 9.8 );
 		expect( formatNumberSpec( 3.032434432432 ) ).toBe( 3.0 );
 		expect( formatNumberSpec( 4.5600000000000005 ) ).toBe( 4.6 );

packages/yoastseo/spec/languageProcessing/helpers/morphology/buildTopicStemsSpec.js

@@ -172,7 +172,7 @@ describe( "A test for topic phrase objects", function() {
 			new StemOriginalPair( "movie", "movies" ),
 			new StemOriginalPair( "work", "work" ),
 		],
-		false,
+		false
 	);
 
 	it( "constructs a topic phrase", () => {
@@ -206,7 +206,7 @@ describe( "A test for topic phrase objects", function() {
 				new StemOriginalPair( "movie", "movie" ),
 				new StemOriginalPair( "work", "work" ),
 			],
-			true,
+			true
 		);
 		expect( exactMatchTopicPhrase.getStems() ).toEqual( [] );
 	} );

packages/yoastseo/spec/languageProcessing/helpers/regex/createWordRegexSpec.js

@@ -1,26 +1,21 @@
-/* eslint-disable no-irregular-whitespace */
 import createWordRegex from "../../../../src/languageProcessing/helpers/regex/createWordRegex.js";
 
 describe( "creates regex from keyword", function() {
 	it( "returns a regex", function() {
 		expect( createWordRegex( "keyword" ) ).toEqual(
-			// eslint-disable-next-line max-len
 			/(^|[ \u00a0\u2014\u06d4\u061f\u060C\u061B\n\r\t.,()”“〝〞〟‟„"+\-;!¡?¿:/»«‹›<>'‘’‛`])keyword($|([ \u00a0\u2014\u06d4\u061f\u060C\u061B\n\r\t.,()”“〝〞〟‟„"+\-;!¡?¿:/»«‹›<>])|((['‘’‛`])([ \u00a0\u2014\u06d4\u061f\u060C\u061B\n\r\t.,()”“〝〞〟‟„"+\-;!¡?¿:/»«‹›<>])))/gi
 		);
 	} );
 	it( "returns a regex - words with diacritics", function() {
 		expect( createWordRegex( "maïs", "", false ) ).toEqual(
-			// eslint-disable-next-line max-len
 			/(^|[ \u00a0\u2014\u06d4\u061f\u060C\u061B\n\r\t.,()”“〝〞〟‟„"+\-;!¡?¿:/»«‹›<>'‘’‛`])maïs($|([ \u00a0\u2014\u06d4\u061f\u060C\u061B\n\r\t.,()”“〝〞〟‟„"+\-;!¡?¿:/»«‹›<>])|((['‘’‛`])([ \u00a0\u2014\u06d4\u061f\u060C\u061B\n\r\t.,()”“〝〞〟‟„"+\-;!¡?¿:/»«‹›<>])))/gi
 		);
 		expect( createWordRegex( "Slovníček pojmû", "", false ) ).toEqual(
-			// eslint-disable-next-line max-len
 			/(^|[ \u00a0\u2014\u06d4\u061f\u060C\u061B\n\r\t.,()”“〝〞〟‟„"+\-;!¡?¿:/»«‹›<>'‘’‛`])Slovníček pojmû($|([ \u00a0\u2014\u06d4\u061f\u060C\u061B\n\r\t.,()”“〝〞〟‟„"+\-;!¡?¿:/»«‹›<>])|((['‘’‛`])([ \u00a0\u2014\u06d4\u061f\u060C\u061B\n\r\t.,()”“〝〞〟‟„"+\-;!¡?¿:/»«‹›<>])))/gi
 		);
 	} );
 	it( "returns a regex - words with characters that break regexes", function() {
 		expect( createWordRegex( "keyword*" ) ).toEqual(
-			// eslint-disable-next-line max-len
 			/(^|[ \u00a0\u2014\u06d4\u061f\u060C\u061B\n\r\t.,()”“〝〞〟‟„"+\-;!¡?¿:/»«‹›<>'‘’‛`])keyword\*($|([ \u00a0\u2014\u06d4\u061f\u060C\u061B\n\r\t.,()”“〝〞〟‟„"+\-;!¡?¿:/»«‹›<>])|((['‘’‛`])([ \u00a0\u2014\u06d4\u061f\u060C\u061B\n\r\t.,()”“〝〞〟‟„"+\-;!¡?¿:/»«‹›<>])))/gi
 		);
 	} );

packages/yoastseo/spec/languageProcessing/helpers/regex/matchStringWithRegexSpec.js

@@ -3,13 +3,13 @@ import regexMatchFunction from "../../../../src/languageProcessing/helpers/regex
 describe( "Matches text with a regex", function() {
 	it( "returns the number of matches", function() {
 		expect( regexMatchFunction( "<p>1</p><p>2</p>", new RegExp( "<p(?:[^>]+)?>(.*?)</p>", "ig" ) ) ).toEqual( [ "<p>1</p>", "<p>2</p>" ] );
-		expect( regexMatchFunction( "<img class=\"alignnone size-medium wp-image-9\" src=\"test.png\" alt=\"image1\" width=\"300\" height=\"36\" />",
-			// eslint-disable-next-line max-len
-			new RegExp( "<img(?:[^>]+)?>", "ig" ) ) ).toEqual( [ "<img class=\"alignnone size-medium wp-image-9\" src=\"test.png\" alt=\"image1\" width=\"300\" height=\"36\" />" ] );
+		expect( regexMatchFunction(
+			"<img class=\"alignnone size-medium wp-image-9\" src=\"test.png\" alt=\"image1\" width=\"300\" height=\"36\" />",
+			new RegExp( "<img(?:[^>]+)?>", "ig" ) )
+		).toEqual( [ "<img class=\"alignnone size-medium wp-image-9\" src=\"test.png\" alt=\"image1\" width=\"300\" height=\"36\" />" ] );
 	} );
 	it( "returns an empty array if there is no matches", function() {
-		// eslint-disable-next-line max-len,no-useless-escape
-		expect( regexMatchFunction( "<img class=\"alignnone size-medium wp-image-9", "<p(?:[^>]+)?>(.*?)<\/p>" ) ).toEqual( [] );
+		expect( regexMatchFunction( "<img class=\"alignnone size-medium wp-image-9", "<p(?:[^>]+)?>(.*?)</p>" ) ).toEqual( [] );
 	} );
 } );
 

packages/yoastseo/spec/languageProcessing/helpers/sentence/SentenceTokenizerSpec.js

@@ -265,8 +265,10 @@ describe( "A test for tokenizing a (html) text into sentences", function() {
 			{ type: "sentence", src: '" in The Musical Times in , who commented "Praise is due to Mr Mercer' },
 			{ type: "full-stop", src: "." },
 		];
-		// eslint-disable-next-line max-len
-		expect( mockTokenizer.getSentencesFromTokens( tokens ) ).toEqual(   [ "The reprint was favourably reviewed by \"A. B.\" in The Musical Times in , who commented \"Praise is due to Mr Mercer." ]  );
+		expect( mockTokenizer.getSentencesFromTokens( tokens ) ).toEqual(
+			[
+				"The reprint was favourably reviewed by \"A. B.\" in The Musical Times in , who commented \"Praise is due to Mr Mercer.",
+			]  );
 	} );
 
 	it( "recognizes sentence boundary when a sentence starts with initials", function() {
@@ -288,8 +290,9 @@ describe( "A test for tokenizing a (html) text into sentences", function() {
 			{ type: "full-stop", src: "." },
 
 		];
-		// eslint-disable-next-line max-len
-		expect( mockTokenizer.getSentencesFromTokens( tokens ) ).toEqual(   [ "This is a sentence.", "E.F. is a good writer.",  "G. H. is a very very great personality." ]  );
+		expect( mockTokenizer.getSentencesFromTokens( tokens ) ).toEqual(
+			[ "This is a sentence.", "E.F. is a good writer.",  "G. H. is a very very great personality." ]
+		);
 	} );
 
 	it( "recognizes sentence boundary when a sentence ends with initials", function() {

packages/yoastseo/spec/languageProcessing/languages/de/helpers/internal/detectAndStemRegularParticipleSpec.js

@@ -1,4 +1,3 @@
-// eslint-disable-next-line max-len
 import { detectAndStemRegularParticiple } from "../../../../../../src/languageProcessing/languages/de/helpers/internal/detectAndStemRegularParticiple";
 import getMorphologyData from "../../../../../specHelpers/getMorphologyData";
 

packages/yoastseo/spec/languageProcessing/languages/es/helpers/checkIfWordIsComplexSpec.js

@@ -8,12 +8,10 @@ describe( "a test checking if the word is complex in Spanish",  function() {
 		expect( checkIfWordIsComplex( wordComplexityConfig, "original", premiumData ) ).toEqual( false );
 	} );
 
-	// eslint-disable-next-line max-len
 	it( "returns plural word form as non-complex if its singular form is found in the list when the singular word form ends with a consonant", function() {
 		expect( checkIfWordIsComplex( wordComplexityConfig, "originales", premiumData ) ).toEqual( false );
 	} );
 
-	// eslint-disable-next-line max-len
 	it( "returns plural word form as non-complex if its singular form is found in the list when the singular word form ends with a vowel", function() {
 		expect( checkIfWordIsComplex( wordComplexityConfig, "parecidos", premiumData ) ).toEqual( false );
 	} );

packages/yoastseo/spec/languageProcessing/languages/ja/helpers/customGetStemmerSpec.js

@@ -8,14 +8,14 @@ const morphologyDataJA = getMorphologyData( "ja" );
 const paper = new Paper(  "これは日本語のテキストです。", { keyword: "日本語のテキスト", locale: "ja" }  );
 
 describe( "Test for getting the helper to return a canonical stem for Japanese word", () => {
-	const mockResearcher = new Researcher( paper );
 	it( "returns the stem when the Japanese morphology data is available", function() {
 		const mockResearcher = new Researcher( paper );
 		mockResearcher.addResearchData( "morphology", morphologyDataJA );
 		expect( customGetStemmer( mockResearcher )( "日帰り" ) ).toEqual( "日帰っ" );
 	} );
 
 	it( "returns the input word if no morphology data is available", () => {
+		const mockResearcher = new Researcher( paper );
 		expect( customGetStemmer( mockResearcher )( "食べる" ) ).toBe( "食べる" );
 	} );
 } );

packages/yoastseo/spec/parse/build/private/getTextElementPositionsSpec.js

@@ -305,15 +305,12 @@ describe( "A test for getting positions of sentences", () => {
 	} );
 
 	it.skip( "should get the correct sentence position for a sentence in an image caption", function() {
-		/* eslint-disable max-len */
 		// html: 	"<p>
 		// 				<img class='size-medium wp-image-33' src='http://basic.wordpress.test/wp-content/uploads/2021/08/cat-3957861_1280-211x300.jpeg' alt='a different cat with toy' width='211' height='300'>
 		// 				</img>
 		// 				A flamboyant cat with a toy<br></br>\n
 		// 			</p>
-		/* eslint-enable max-len */
 
-		// eslint-disable-next-line max-len
 		const html = "<p><img class='size-medium wp-image-33' src='http://basic.wordpress.test/wp-content/uploads/2021/08/cat-3957861_1280-211x300.jpeg' alt='a different cat with toy' width='211' height='300'></img>A flamboyant cat with a toy<br></br>\n</p>";
 
 		const tree = adapt( parseFragment( html, { sourceCodeLocationInfo: true } ) );

packages/yoastseo/spec/scoring/InclusiveLanguageAssessorSpec.js

@@ -230,8 +230,9 @@ describe( "a test for the inclusive language assessor when run in Shopify", () =
 		const assessor = new InclusiveLanguageAssessor( researcher, options );
 		assessor._assessments.forEach( assessment => {
 			if ( assessment.isApplicable( mockPaper, researcher ) ) {
-				// eslint-disable-next-line max-len
-				expect( assessment.learnMoreUrl ).toEqual( `<a href='https://yoa.st/inclusive-language-${ assessment.category }-shopify' target='_blank'>` );
+				expect( assessment.learnMoreUrl ).toEqual(
+					`<a href='https://yoa.st/inclusive-language-${ assessment.category }-shopify' target='_blank'>`
+				);
 			}
 		} );
 	} );

packages/yoastseo/spec/scoring/assessments/assessmentSpec.js

@@ -44,7 +44,6 @@ describe( "test hasEnoughContentForAssessment", () => {
 
 	it( "should return false if text is 49 chars and an image and no specification for contentNeededForAssessment", () => {
 		const mockPaper = new Paper( "This text contains forty-nine characterssssssssss" +
-			// eslint-disable-next-line max-len
 			"<figure class=\"wp-block-image size-large\"><img src=\"http://basic.wordpress.test/wp-content/uploads/2022/05/70860665-c6b2-4b40-82e9-37b4bea5648e-3-1024x682.jpeg\" alt=\"\" class=\"wp-image-148\"/></figure>" );
 		const mockAssessment = new Assessment();
 

packages/yoastseo/spec/scoring/assessments/inclusiveLanguage/helpers/isFollowedAndPrecededByExceptionSpec.js

@@ -1,5 +1,7 @@
-// eslint-disable-next-line max-len
-import { isFollowedAndPrecededByException, isNotFollowedAndPrecededByException } from "../../../../../src/scoring/assessments/inclusiveLanguage/helpers/isFollowedAndPrecededByException";
+import {
+	isFollowedAndPrecededByException,
+	isNotFollowedAndPrecededByException,
+} from "../../../../../src/scoring/assessments/inclusiveLanguage/helpers/isFollowedAndPrecededByException";
 
 describe( "Test isFollowedAndPrecededByException", () => {
 	it( "returns true when a term is both followed and preceded by an exception", () => {